From 4ca4c900cca5664a4f419b59b8bda5054854ff42 Mon Sep 17 00:00:00 2001 From: woothu <32914662+woothu@users.noreply.github.com> Date: Fri, 5 Jun 2020 09:38:34 +0200 Subject: [PATCH] refactor: small fixes --- package-lock.json | 10 ++--- package.json | 2 +- src/assets/icons/icons.js | 4 +- src/containers/TheContainer.vue | 2 +- src/views/base/Forms.vue | 4 +- src/views/base/Paginations.vue | 2 - src/views/buttons/BrandButtons.vue | 4 +- src/views/notifications/Modals.vue | 1 + .../__snapshots__/TheContainer.spec.js.snap | 4 +- .../__snapshots__/Paginations.spec.js.snap | 2 - .../__snapshots__/BrandButtons.spec.js.snap | 42 +++++++++---------- .../__snapshots__/Modals.spec.js.snap | 1 + 12 files changed, 38 insertions(+), 40 deletions(-) diff --git a/package-lock.json b/package-lock.json index 8b9f8991..2cbac16a 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1850,14 +1850,14 @@ } }, "@vue/cli-plugin-e2e-nightwatch": { - "version": "4.4.1", - "resolved": "https://registry.npmjs.org/@vue/cli-plugin-e2e-nightwatch/-/cli-plugin-e2e-nightwatch-4.4.1.tgz", - "integrity": "sha512-6874oYjUVmaoeQPlyNf2IqeG/7hX0hbjvJg+cn1wKn//e8rQu5f2G3rNOAor5N9E8xUsXcKSj5fH7LqrHXgZGg==", + "version": "4.3.1", + "resolved": "https://registry.npmjs.org/@vue/cli-plugin-e2e-nightwatch/-/cli-plugin-e2e-nightwatch-4.3.1.tgz", + "integrity": "sha512-5g46AV2z+8etx89O+FQLQuKkuEx75e9Y5v49iQgnbMMuDYT4bizilk4RyO/R3Tq/ePUHfyq10b0trROmG40JvQ==", "dev": true, "requires": { - "@vue/cli-shared-utils": "^4.4.1", + "@vue/cli-shared-utils": "^4.3.1", "deepmerge": "^4.2.2", - "nightwatch": "^1.3.5" + "nightwatch": "^1.3.4" } }, "@vue/cli-plugin-eslint": { diff --git a/package.json b/package.json index 0ef25f09..7ce86f85 100644 --- a/package.json +++ b/package.json @@ -43,7 +43,7 @@ "devDependencies": { "@babel/core": "~7.10.2", "@vue/cli-plugin-babel": "~4.4.1", - "@vue/cli-plugin-e2e-nightwatch": "~4.4.1", + "@vue/cli-plugin-e2e-nightwatch": "~4.3.1", "@vue/cli-plugin-eslint": "~4.4.1", "@vue/cli-plugin-unit-jest": "~4.4.1", "@vue/cli-service": "~4.4.1", diff --git a/src/assets/icons/icons.js b/src/assets/icons/icons.js index 0ad0cd1d..982b86cc 100644 --- a/src/assets/icons/icons.js +++ b/src/assets/icons/icons.js @@ -6,7 +6,7 @@ import { cibTumblr, cibXing, cibGithub, - cibStackOverflow, + cibStackoverflow, cibYoutube, cibDribbble, cibInstagram, @@ -147,7 +147,7 @@ export const iconsSet = Object.assign( cibTumblr, cibXing, cibGithub, - cibStackOverflow, + cibStackoverflow, cibYoutube, cibDribbble, cibInstagram, diff --git a/src/containers/TheContainer.vue b/src/containers/TheContainer.vue index d0f7f6e9..ecaa7df2 100644 --- a/src/containers/TheContainer.vue +++ b/src/containers/TheContainer.vue @@ -11,8 +11,8 @@ - + diff --git a/src/views/base/Forms.vue b/src/views/base/Forms.vue index 9ac47812..a0d734d8 100644 --- a/src/views/base/Forms.vue +++ b/src/views/base/Forms.vue @@ -859,11 +859,11 @@ export default { selectOptions: [ 'Option 1', 'Option 2', 'Option 3', { - value: ['some value', 'another value'], + value: 'some value', label: 'Selected option' } ], - selectedOption: ['some value', 'another value'], + selectedOption: 'some value', formCollapsed: true, checkboxNames: ['Checkboxes', 'Inline Checkboxes', diff --git a/src/views/base/Paginations.vue b/src/views/base/Paginations.vue index 5188e21d..b9d9abd4 100644 --- a/src/views/base/Paginations.vue +++ b/src/views/base/Paginations.vue @@ -21,7 +21,6 @@
@@ -38,7 +37,6 @@ size="lg" :active-page.sync="currentPage" :pages="10" - responsive />
diff --git a/src/views/buttons/BrandButtons.vue b/src/views/buttons/BrandButtons.vue index e43dfd13..f79d11d3 100644 --- a/src/views/buttons/BrandButtons.vue +++ b/src/views/buttons/BrandButtons.vue @@ -183,7 +183,7 @@ export default { 'tumblr', 'xing', 'github', - 'stack-overflow', + 'stackoverflow', 'youtube', 'dribbble', 'instagram', @@ -202,7 +202,7 @@ export default { // tumblr: 'Tumblr', // xing: 'Xing', // github: 'Github', - // 'stack-overflow': 'StackOverflow', + // stackoverflow: 'StackOverflow', // youtube: 'YouTube', // dribbble: 'Dribbble', // instagram: 'Instagram', diff --git a/src/views/notifications/Modals.vue b/src/views/notifications/Modals.vue index a405b053..301010c8 100644 --- a/src/views/notifications/Modals.vue +++ b/src/views/notifications/Modals.vue @@ -55,6 +55,7 @@ Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua. Ut enim ad minim veniam, diff --git a/tests/unit/containers/__snapshots__/TheContainer.spec.js.snap b/tests/unit/containers/__snapshots__/TheContainer.spec.js.snap index 11e20061..6e1ca26c 100644 --- a/tests/unit/containers/__snapshots__/TheContainer.spec.js.snap +++ b/tests/unit/containers/__snapshots__/TheContainer.spec.js.snap @@ -26,9 +26,9 @@ exports[`TheContainer.vue renders correctly 1`] = ` /> - - + + `; diff --git a/tests/unit/views/base/__snapshots__/Paginations.spec.js.snap b/tests/unit/views/base/__snapshots__/Paginations.spec.js.snap index 6b48e588..ab28c3c5 100644 --- a/tests/unit/views/base/__snapshots__/Paginations.spec.js.snap +++ b/tests/unit/views/base/__snapshots__/Paginations.spec.js.snap @@ -47,7 +47,6 @@ exports[`Paginations.vue renders correctly 1`] = ` doublearrows="true" limit="5" pages="10" - responsive="" />
@@ -84,7 +83,6 @@ exports[`Paginations.vue renders correctly 1`] = ` doublearrows="true" limit="5" pages="10" - responsive="" size="lg" /> diff --git a/tests/unit/views/buttons/__snapshots__/BrandButtons.spec.js.snap b/tests/unit/views/buttons/__snapshots__/BrandButtons.spec.js.snap index e9dbcb16..b11b4457 100644 --- a/tests/unit/views/buttons/__snapshots__/BrandButtons.spec.js.snap +++ b/tests/unit/views/buttons/__snapshots__/BrandButtons.spec.js.snap @@ -188,8 +188,8 @@ exports[`BrandButtons.vue renders correctly 1`] = `